Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update Python build instructions [skip-ci] #898

Merged
merged 3 commits into from
Oct 6, 2022
Merged

[REVIEW] Update Python build instructions [skip-ci] #898

merged 3 commits into from
Oct 6, 2022

Conversation

betatim
Copy link
Member

@betatim betatim commented Oct 6, 2022

This explicilty mentions that nvcc has to be installed manually and updates the build and pytest commands.

@betatim
Update build instructions
44e720d 
This explicilty mentions that nvcc has to be installed manually and
updates the build and pytest commands.
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 6, 2022
@wphicks
Copy link
Contributor

wphicks commented Oct 6, 2022

@betatim Could you retarget this to 22.12, given that we're at code freeze for 22.10? Otherwise, looks great! Very useful improvements.

@cjnolet
Copy link
Member

cjnolet commented Oct 6, 2022 •
edited
Loading

Sorry @wphicks, I actually plan to include this in 22.10 since it's just a simple README change. I just realized I didn't have it targeted for the 22.10 release board.

cjnolet
cjnolet requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Tim! Just one little change but otherwise it looks great.

BUILD.md
python setup.py build_ext --inplace
python setup.py install
# to build pylibraft
./build.sh libraft pylibraft --install --compile-libs
Copy link
Member

@cjnolet cjnolet Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great to have the build.sh variants in here as well but i'd like to also keep the manual build instructions for developers to know that the other method can be used in addition to build.sh.

I think it would be best to include both, and maybe move the setup.py can also be used to build the Python APIs manually after the build.sh instructions?

@cjnolet cjnolet changed the title [REVIEW] Update Python build instructions [REVIEW] Update Python build instructions [skip-ci] Oct 6, 2022
@cjnolet
Copy link
Member

cjnolet commented Oct 6, 2022 •
edited
Loading

Some issues we've encountered recently in CI required that we remove the explicit (re-)building of the python packages from build.sh. This also means that build.sh docs no longer builds the python packages, which are required to be built, in order to build the docs. I've also added this to the BUILD docs.

@cjnolet
Copy link
Member

cjnolet commented Oct 6, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9b7861a into rapidsai:branch-22.10 Oct 6, 2022
@betatim betatim deleted the update-python-docs branch October 7, 2022 07:11
@betatim
Copy link
Member Author

betatim commented Oct 7, 2022

Thanks for the comments and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betatim @wphicks @cjnolet